solution#986
Open
u5135039754-dev wants to merge 140 commits into
Open
Conversation
Anton-Kuchmasov
suggested changes
May 4, 2026
Anton-Kuchmasov
left a comment
Anton-Kuchmasov
left a comment
There was a problem hiding this comment.
There are a few critical deploy' issues need tp be fixed. Please re-deploy your App, double-check if everything is OK and then re-request review again
thread in fe_chat: https://mate.academy/chats/20607?selectedMessageId=11281255
brespect
suggested changes
May 6, 2026
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Good progress, but for now i can't open your DEMO LINK, also make sure that you pass all tests before requesting next review
Update Node.js version to 20.x in setup
- Set base to /react_phone-catalog/ during build - Keep base as / during development for local testing - Ensures GitHub Pages deployment works correctly
brespect
suggested changes
May 21, 2026
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Good progress, check next:
- When I select something in this scetion, the page should scrolls up. but got not found instead:
- Not found Page should has Header and Footer as other pages.
- Don't show the counters when there is nothing in Favourites/Cart:
- Don't use same image three times in slider, let's add another one:
- Let's reduce the size of font on Mobile screen:
Denys-Kravchuk9988
suggested changes
May 21, 2026
Denys-Kravchuk9988
left a comment
Denys-Kravchuk9988
left a comment
There was a problem hiding this comment.
Good job!
A few things to improve:
- The slider doesn't reset timer when I click on sticks. When I open second slide wait 3-4 seconds and then press prev stick the first slide is immediately switched to second slide.
- I would recommend to add
cursor: pointerby hover on interactive image
- It's better to add some loading state for this page and when color and configurations are changed
- Plus/Minus buttons are better to be in a column
-
I would recommend to disable scrolling when menu is open (on main page it's already disabled)
-
In cart I have two products but I don't see any badge here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo